Re: [linux-usb-devel] [PATCH 02/02] USB: add dynamic id functionalityto USB core

[Alan Stern]

On Thu, 17 Nov 2005, Greg KH wrote:

> > > +	fields = sscanf(buf, "%x %x", &idVendor, &idProduct);
> > > +	if (fields < 0)
> > > +		return -EINVAL;
> > 
> > Don't you want to test (fields < 2)?
> 
> No, it's ok to just specify the vendor, if you want a product of 0 :)
> 
> PCI does it this way too.

Well, in that case shouldn't you test (fields < 1)?

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/