Re: [PATCH 2/10] kdump: dynamic per cpu allocation of memory for saving cpu registers

[Vivek Goyal]

On Thu, Nov 17, 2005 at 02:01:38PM -0800, Andrew Morton wrote:
> 
> Please always generate diffs against the latest kernel!  I changed the
> patch to reflect the new location of ppc64's machine_kexec.c.
> 

Sorry. That's a mistake. I shall take care of it next time onwards.

> In that file, I notice that this comment has become more informative:
> 
> /*
>  * Provide a dummy crash_notes definition until crash dump is implemented.
>  * This prevents breakage of crash_notes attribute in kernel/ksysfs.c.
>  */
> note_buf_t crash_notes[NR_CPUS];
> 
> Please check that with your new implementation, the above "breakage"
> (whatever it was) remains fixed.
>

With this patchset "crash_notes" has been moved in architecture independent
portion (). Hence there is no need for architecture dependent definitions.
So this change should be fine.

Thanks
Vivek 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/