[PATCH 2/3] cciss: bug fix for BIG_PASS_THRU

From: mikem
Date: Fri Nov 18 2005 - 11:40:57 EST


Patch 2 of 3

Applications using CCISS_BIG_PASSTHRU complained that the data written
was zeros. The code looked alright, but it seems that copy_from_user
already does a memset on the buffer. Removing it from the pass-through
fixes the apps.

Please consider this for inclusion.

Signed-off-by: Mike Miller <mike.miller@xxxxxx>
--------------------------------------------------------------------------------

drivers/block/cciss.c | 2 --
1 files changed, 2 deletions(-)

diff -puN drivers/block/cciss.c~cciss_memset drivers/block/cciss.c
--- linux-2.6.14.2/drivers/block/cciss.c~cciss_memset 2005-11-15 15:41:23.289070160 -0600
+++ linux-2.6.14.2-mikem/drivers/block/cciss.c 2005-11-15 15:42:28.264192440 -0600
@@ -1020,8 +1020,6 @@ static int cciss_ioctl(struct inode *ino
copy_from_user(buff[sg_used], data_ptr, sz)) {
status = -ENOMEM;
goto cleanup1;
- } else {
- memset(buff[sg_used], 0, sz);
}
left -= sz;
data_ptr += sz;
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/