Re: [PATCH 3/5] slab: extract slabinfo header printing to separatefunction

From: Manfred Spraul
Date: Sat Nov 19 2005 - 07:10:59 EST

Pekka Enberg wrote:


-static void *s_start(struct seq_file *m, loff_t *pos)
+static inline void print_slabinfo_header(struct seq_file *m)

Why inline? I try to avoid adding inline wherever possible. inline is actually always_inline force_inline compiler_we_know_it_better_this_must_be_inlined.
I only use inline in the hot path (kmem_cache_alloc/kmalloc+free) and where I know that lots of code will be optimized away due to constant propagation. In this case, there is no reason to force the compiler to inline the function, thus I wouldn't add an inline.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at