Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386

From: Sam Ravnborg
Date: Sat Nov 19 2005 - 15:59:42 EST


On Sat, Nov 19, 2005 at 09:51:20PM +0100, Adrian Bunk wrote:
> On Sat, Nov 19, 2005 at 01:34:35AM +0100, Sam Ravnborg wrote:
> > On Thu, Nov 17, 2005 at 08:03:54PM -0800, Andrew Morton wrote:
> > > "David S. Miller" <davem@xxxxxxxxxxxxx> wrote:
> > > >
> > > > The deprecated warnings are so easy to filter out, so I don't think
> > > > noise is a good argument. I see them all the time too.
> > >
> > > That works for you and me. But how to train all those people who write
> > > warny patches?
> >
> > Would it work to use -Werror only on some parts of the kernel.
> > Thinking of teaching kbuild to recursively apply a flags to gcc.
> >
> > Then we could say that kernel/ should be warning free (to a start).
>
> We can do better as we do currently, but we cannever get the kernel 100%
> warning free for all supported kernel configurations and all supported
> gcc versions.
>
> E.g. gcc emitting some "unused variable" warnings when compiling with
> CONFIG_PCI=n is quite common, and although they could all be fixed there
> will always be some warnings with unusual kernel configurations.

I had no issue with adding more gcc flags, but this is a very valid
argument. So I will for now not do it.
>From a kbuild perspective it could be useful in other situations
to have the possibility to add a variable that was set also and only in
sub-directories. But I will not dive into it before a better reason show
up.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/