Re: [PATCH] add ->getgeo block device method

[Bodo Eggert]

On Sat, 19 Nov 2005, Christoph Hellwig wrote:

> HDIO_GETGEO is implemented in most block drivers, and all of them have
> to duplicate the code to copy the structure to userspace, aswell as
> getting the start sector.  This patch moves that to common code [1]
> and adds a ->getgeo method to fill out the raw kernel hd_geometry
> structure.  For many drivers this means ->ioctl can go away now.
> 
> [1] the s390 block drivers are odd in this respect.  xpram sets ->start
>     to 4 always which seems more than odd, and the dasd driver shifts
>     the start offset around, probably because of it's non-standard
>     sector size.

Shouldn't there be a field for the sector size, or is the 512 bytes size 
too hardcoded to fix so this field wouldn't matter?

-- 
Top 100 things you don't want the sysadmin to say:
68. Hmmm, curious...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/