Re: I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c)

[Nish Aravamudan]

On 11/20/05, Bodo Eggert <harvested.in.lkml@xxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> Daniel Marjamäki <daniel.marjamaki@xxxxxxxxx> wrote:
>
> > -     aztTimeOutCount = 0;
> > +     aztTimeOut = jiffies + 2;
>
> Different timeout based on HZ seems wrong.

True; I'm trying to think of a good way to emulate 8000000 iterations
of loop, though. Really, this is not terrible to use 2 jiffies of
offset, as we try to sleep 1 jiffy each time. As long as we don't get
a signal *right* away, we'll sleep probably for 2 loops. Not sure,
though, may be useful to see what happens in practice and then debug
further for the right value.

May also want to use time_after_eq() not time_after().

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/