Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference

[Adrian Bunk]

On Mon, Nov 21, 2005 at 12:46:12AM +0100, Adrian Bunk wrote:
> On Sun, Nov 20, 2005 at 06:33:51PM -0500, Jody McIntyre wrote:
> > On Mon, Nov 21, 2005 at 12:20:09AM +0100, Adrian Bunk wrote:
> > > +	if(cache->filled_head)
> > > +		kfree(cache->filled_head);
> > 
> > Try again.  kfree() of a NULL pointer is perfectly fine.
> 
> The problem is that cache is NULL...

And my patch didn't fix this...

What about the second try of my patch?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/