Re: I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c)

[Con Kolivas]

On Mon, 21 Nov 2005 19:09, Daniel Marjamäki wrote:
> Bodo Eggert wrote:
> > Daniel Marjamäki <daniel.marjamaki@xxxxxxxxx> wrote:
> >>-     aztTimeOutCount = 0;
> >>+     aztTimeOut = jiffies + 2;
> >
> > Different timeout based on HZ seems wrong.
>
> Yes, but..
>
> If I'd say "HZ/100", then all systems that uses my driver must have
> HZ>=200.
>
> The way I do it:
> All systems will give me a delay for at least a few ms.
> I get the shortest timeout possible on each computer.

Convention in the kernel would be 
	aztTimeOut =  HZ / 100 ? : 1;
to be at least one tick (works for HZ even below 100) and is at least 10ms. If 
you wanted 2 ms then use
	aztTimeOut =  HZ / 500 ? : 1;
which would give you at least 2ms

Cheers,
Con
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/