Re: (no subject)

From: Keir Fraser
Date: Mon Nov 21 2005 - 05:03:46 EST



On 18 Nov 2005, at 16:05, Andi Kleen wrote:

I don't think you can do that. We still need these functions in low
level architecture code at least.

Using __pa/__va doesn't cut it because it won't work on Xen guests
which have different views on bus vs physical addresses. The Xen
code is (hopefully) in the process of being merged, so intentionally
breaking them isn't a good idea.

So if anything there would need to be replacement functions for it
first that do the same thing. But why not just keep the old ones?

We could make use of virt_to_machine/machine_to_virt instead, which arguably better describe the intent of those functions. Currently we only use virt_to_bus/bus_to_virt in our swiotlb implementation, and our modified dma_map code. In those files I think the existing function names make some sense, but we can easily change if that's preferred.

-- Keir

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/