Re: I made a patch and would like feedback/testers (drivers/cdrom/aztcd.c)

[Bodo Eggert]

On Mon, 21 Nov 2005, Con Kolivas wrote:
> On Mon, 21 Nov 2005 19:09, Daniel Marjamäki wrote:

> > The way I do it:
> > All systems will give me a delay for at least a few ms.
> > I get the shortest timeout possible on each computer.
> 
> Convention in the kernel would be 
> 	aztTimeOut =  HZ / 100 ? : 1;
> to be at least one tick (works for HZ even below 100) and is at least 10ms.

You have to add one to the timeout, since you might be just before the end 
of the timeslice when the delay starts. aztTimeOut = (HZ / 100 ? : 1) + 1;

-- 
Top 100 things you don't want the sysadmin to say:
11. Can you get VMS for this Sparc thingy?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/