Re: [PATCH -mm2] net: Fix compiler-error on dgrs.c when !CONFIG_PCI

From: Richard Knutsson
Date: Mon Nov 21 2005 - 16:42:22 EST

Herbert Xu wrote:

On Mon, Nov 21, 2005 at 01:52:49PM +0100, Richard Knutsson wrote:

This patch requirer the "net-fix-compiler-error-on-dgrsc-when-config_pci.patch" (added to the -mm tree after 2.6.15-rc1-mm2):

--- devel/drivers/net/dgrs.c~net-fix-compiler-error-on-dgrsc-when-config_pci 2005-11-19 18:00:34.000000000 -0800
+++ devel-akpm/drivers/net/dgrs.c 2005-11-19 18:00:34.000000000 -0800
@@ -1458,6 +1458,8 @@ static struct pci_driver dgrs_pci_driver
.probe = dgrs_pci_probe,
.remove = __devexit_p(dgrs_pci_remove),
+static struct pci_driver dgrs_pci_driver = {};

I don't see the point. We shouldn't have this structure at all
if CONFIG_PCI is not set.


We need it even if pci_register_driver() and pci_register_driver() is empty shells. And instead of removing #endif CONFIG_PCI for dgrs_pci_driver, which needs dgrs_pci_tbl, dgrs_pci_probe() and dgrs_pci_remove() (and so on), I added the empty dgrs_pci_driver-structure.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at