Re: [2.6 patch] drivers/ieee1394/csr1212.c: remove dead code

[Jody McIntyre]

On Mon, Nov 21, 2005 at 11:02:10PM +0100, Stefan Richter wrote:

> -		if (dentry->kv->key.id == CSR1212_KV_ID_EXTENDED_ROM) {
> -			csr1212_get_keyval(csr, dentry->kv);
> -
> +		if (dentry->kv->key.id == CSR1212_KV_ID_EXTENDED_ROM &&
> +		    !dentry->kv->valid) {
> +			ret = _csr1212_read_keyval(csr, dentry->kv);
>  			if (ret != CSR1212_SUCCESS)
>  				return ret;
>  		}

Duh :/

> Although I am not quite sure if the check for !valid is really required. 
> It certainly cannot hurt.

That's a separate issue so it should be a separate patch.  I'll do it
though.

Cheers,
Jody

> -- 
> Stefan Richter
> -=====-=-=-= =-== =-=-=
> http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/