Re: [patch 2/2] Convert bigsmp to use flat physical mode

From: Andi Kleen
Date: Tue Nov 22 2005 - 03:55:53 EST


On Mon, Nov 21, 2005 at 05:04:11PM -0800, Ashok Raj wrote:
> On Mon, Nov 21, 2005 at 03:39:16PM -0800, Ashok Raj wrote:
> >
> > - if ((num_processors > 8) &&
> > - APIC_XAPIC(ver) &&
> > - (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL))
> > + if (APIC_XAPIC(ver) &&
> > + (CPU_HOTPLUG_ENABLED ||
> > + ((num_processors > 8) &&
> > + (boot_cpu_data.x86_vendor ==
> > X86_VENDOR_INTEL))))
> > def_to_bigsmp = 1;
>
> Noticed that Andi send one more patch do enable bigsmp for AMD (i386), and the
> APIC_XAPIC() check was not properly placed to factor this in. This updated
> patch should work for AMD as well, and switch to bigsmp when we have hotplug
> enabled.

Looks good thanks.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/