Re: [PATCH 2/5] Light Fragmentation Avoidance V20: 002_usemap

From: Mel Gorman
Date: Tue Nov 22 2005 - 06:11:34 EST


On Tue, 22 Nov 2005, KAMEZAWA Hiroyuki wrote:

> Mel Gorman wrote:
> > > #define PG_checked 8 /* kill me in 2.5.<early>. */
> > >
> > > ?
> > >
> > > At least PG_uncached isn't used on many architectures too, so could
> > > be reused. I don't know why those that use it don't check VMAs instead.
> > >
> >
> >
> > PG_unchecked appears to be totally unused. It's only users are the macros
> > that manipulate the bit and mm/page_alloc.c . It appears it has been a
> > long time since it was used to it is a canditate for reuse.
> >
>
> Just a notification..
> from 2.6.14
>
> PageUncached 375 include/asm-ia64/uaccess.h if (PageUncached(page))
> PageUncached 393 include/asm-ia64/uaccess.h if (PageUncached(page))
>
> This is used by /dev/mem
>
>
> PageChecked 196 fs/afs/dir.c if (!PageChecked(page))
> PageChecked 169 fs/ext2/dir.c if (!PageChecked(page))
> PageChecked 1372 fs/ext3/inode.c if (!page_has_buffers(page) ||
> PageChecked(page)) {
> PageChecked 1441 fs/ext3/inode.c WARN_ON(PageChecked(page));
> PageChecked 2350 fs/reiserfs/inode.c int checked =
> PageChecked(page);
> PageChecked 2853 fs/reiserfs/inode.c WARN_ON(PageChecked(page));
>
> This is used by fs, now.
>

d'oh. I was looking for the flags, not the macros :(

--
Mel Gorman
Part-time Phd Student Java Applications Developer
University of Limerick IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/