Re: [2.6.14] bug in inet_connection_sock.c -> lowest port alwaysskipped

[Folkert van Heusden]

> >There seems to be a small bug in inet_connection_sock.c: the lowest port
> >set using sysctl (taken from 'sysctl_local_port_range') is always
> >skipped in the first iteration.
> >In inet_csk_get_port one can find this:
> >                if (hashinfo->port_rover < low)
> >                        rover = low;
> >                else
> >                        rover = hashinfo->port_rover;
> >                do {
> >                        rover++;
> >As you can see the first statement is a ++ causing the first port to
> >always be skipped.
> This has already been fixed three weeks ago by Stephen Hemminger's port
> randomization patch.

Great!


Folkert van Heusden

-- 
Try MultiTail! Multiple windows with logfiles, filtered with regular
expressions, colored output, etc. etc. www.vanheusden.com/multitail/
----------------------------------------------------------------------
Get your PGP/GPG key signed at www.biglumber.com!
----------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/