Re: PageReserved removal woes: vbetool, suspend-to-ram breakage

From: Hugh Dickins
Date: Tue Nov 22 2005 - 14:51:35 EST


On Tue, 22 Nov 2005, Matthew Garrett wrote:
> Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > Just wanted to let you know that the warning introduced in
> > [PATCH] core remove PageReserved
>
> It's not much of a warning, it seems to stop vbetool from working (which
> may explain a few complaints about ACPI suspend being broken in 2.6.15 -
> it's not, but vbetool is...)
>
> vbetool (well, strictly it's LRMI, but...) needs to access real-mode
> memory. On the other hand, it's probably a bad idea to let it actually
> scribble over RAM that the kernel may be using. So
> MAP_PRIVATE|PROT_WRITE seems to be the correct thing to do. This
> certainly /seemed/ to work in older kernels, but doesn't any more. What
> should I be doing instead?
>
> (I'm also not quite sure why the error claims that it's deprecated,
> whereas in fact it doesn't actually work at all. Breaking userspace
> without warning isn't terribly nice)

Sorry about that, we really didn't expect that it was being used.
And sorry I didn't get the fixes ready in time for 2.6.15-rc2.
But they've gone into Linus' git tree a couple of hours ago.
Please let me know if tomorrow's 2.6.15-rc2-git3 does not work for you.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/