Re: 2.6.15-rc1-mm2 0x414 Bad page states

[Hugh Dickins]

On Tue, 22 Nov 2005, Michael Frank wrote:
> 
> I am getting this also with i810 drm in Vanilla 2.6.15-rc2 
> upon exiting apps such as supertux.

Aha, perhaps you're the one we've been waiting for.  I've suspected
a DRM issue, but nobody has actually seen one until now, and I didn't
want to put in a patch without live justification.

Would you please try the patch below, and let us know if it fixes your
problem.  If so, I'll send it off to Andrew and Linus: the rest of the
PageReserved fixes, including the sound driver Bad page state fixes,
have gone into Linus' git tree today: perhaps this is the missing piece.

If this does not work for you, then presumably you'd be another sound
driver sufferer?  and I should send you that patch (or you pick it up
from yesterday's LKML).  But right now I'd selfishly like you to test
just this DRM patch below.

Thanks,
Hugh

--- 2.6.15-rc2/drivers/char/drm/drm_memory.c	2005-11-20 19:43:39.000000000 +0000
+++ linux/drivers/char/drm/drm_memory.c	2005-11-21 10:10:45.000000000 +0000
@@ -95,7 +95,7 @@ unsigned long drm_alloc_pages(int order,
 	unsigned long addr;
 	unsigned int sz;
 
-	address = __get_free_pages(GFP_KERNEL, order);
+	address = __get_free_pages(GFP_KERNEL|__GFP_COMP, order);
 	if (!address)
 		return 0;
 
--- 2.6.15-rc2/drivers/char/drm/drm_memory_debug.h	2005-11-20 19:43:39.000000000 +0000
+++ linux/drivers/char/drm/drm_memory_debug.h	2005-11-21 10:11:04.000000000 +0000
@@ -221,7 +221,7 @@ unsigned long DRM(alloc_pages) (int orde
 	}
 	spin_unlock(&DRM(mem_lock));
 
-	address = __get_free_pages(GFP_KERNEL, order);
+	address = __get_free_pages(GFP_KERNEL|__GFP_COMP, order);
 	if (!address) {
 		spin_lock(&DRM(mem_lock));
 		++DRM(mem_stats)[area].fail_count;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/