[PATCH 0/2] - usbserial: Adds missing checks and bug fix.

From: Luiz Fernando Capitulino
Date: Tue Nov 22 2005 - 16:59:40 EST


I'm sending two patches for the usbserial NULL pointer dereference we
discussed last week:


The first patch adds the missing checks you suggested we should use in
usb-serial driver's entry points, to avoid NULL pointer dereferences.

The second one is the same I've sent before, except that now I'm using
down() in serial_close() instead of down_interruptible() (as you also
suggested). I didn't use down() in the first version because I don't
wanted processes in a close() waiting for a open() too long. But
Eduardo Habkost showed me it will not happen: the only possibility for a
open() to sleep after the semaphore was acquired, is when 'open_count'
equals 1, and there will be no close, since the port is being opened for the
first time.

It's ok for a open() to wait a close().

Both patches were tested with a pl2303 device, running hundreds of my
test-case and using minicom in parallel.

Luiz Fernando N. Capitulino
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/