Re: pivot_root broken in 2.6.15-rc1-mm2

[Neil Brown]

On Wednesday November 23, viro@xxxxxxxxxxxxxxxx wrote:
> On Wed, Nov 23, 2005 at 01:07:28PM +1100, Neil Brown wrote:
> > After putting in copious tracing printk, the offending test is:
> > 
> > 	if (user_nd.mnt->mnt_parent == user_nd.mnt)
> > 		goto out2; /* not attached */
> > 
> > If I remove this, it works (or seems to).
> > Presumably the initial root file system is 'not attached'.  But that
> > shouldn't be a problem, should it?
> 
> Initial root is root and will remain root, period.
> 
> > Could this be related to the new shared mounts stuff???
> 
> No.  And no, it's not going to change - any memory you win on killing
> initramfs is not going to be worth the extra code needed to special-case
> it.

Ah, OK.
It's just that pivot_root works in this context in 2.6.11.9, so I
figured it was a breakage.

I'll go read ramfs-rootfs-initramfs.txt 

Thanks,
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/