Re: [PATCH]: Free pages from local pcp lists under tight memoryconditions

[Christoph Lameter]

On Wed, 23 Nov 2005, Linus Torvalds wrote:

> On Tue, 22 Nov 2005, Christoph Lameter wrote:
> > On Tue, 22 Nov 2005, Andrew Morton wrote:
> > > +extern int drain_local_pages(void);
> > drain_cpu_pcps?
> 
> Please no.
> 
> If there is something I _hate_ it's bad naming. And "pcps" is a totally 
> unintelligible name.
> 
> Write it out. If a function is so trivial that you can't be bothered to 
> write out what the name means, that function shouldn't exist at all. 
> Conversely, if it's worth doing, it's worth writing out a name.


drain_one_cpus_pages_from_per_cpu_pagesets()

drain_one_cpus_remote_pages_from_per_cpu_pagesets()

drain_all_per_cpu_pagesets()

?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/