Re: [usb-storage] Re: [PATCH] usb-storage: Add support for Rio Karma

[Alan Stern]

On Wed, 23 Nov 2005, Bob Copeland wrote:

> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -145,6 +145,13 @@ UNUSUAL_DEV(  0x0451, 0x5416, 0x0100, 0x
>  		US_SC_DEVICE, US_PR_BULK, NULL,
>  		US_FL_NEED_OVERRIDE ),
>  
> +#ifdef CONFIG_USB_STORAGE_KARMA
> +UNUSUAL_DEV(  0x045a, 0x5210, 0x0101, 0x0101,
> +		"Rio",
> +		"Rio Karma",
> +		US_SC_SCSI, US_PR_BULK, rio_karma_init, US_FL_FIX_INQUIRY),

Are you sure you need US_SC_SCSI and US_PR_BULK?  Wouldn't US_SC_DEVICE 
and US_PR_DEVICE be sufficient?

And do you really need US_FL_FIX_INQUIRY?  Hardly any devices do (maybe 
none).

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/