Re: overlapping resources for platform devices?

[Russell King]

On Wed, Nov 23, 2005 at 12:48:55PM -0600, Kumar Gala wrote:
> On Wed, 23 Nov 2005, Russell King wrote:
> 
> > On Wed, Nov 23, 2005 at 12:57:40AM -0600, Kumar Gala wrote:
> > > Any update?
> > 
> > It should be okay, but I'll step back from saying "safe" because
> > I don't particularly like the insert_resource() concept.
> 
> Ok. Not sure how to take that.  Would you prefer we work around this some 
> other way? or your willing to take a patch but just hesitant about it 
> breaking something?

PCI survived this change, so I've no doubt that platform devices will
survive.  I just don't like it on a personal level because I worry
about the possibility of inappropriately inserting a resource above
some other resource.

Theoretically, if you have two platform devices which are mutually
exclusive, but use exactly the same resource range, with the existing
system only one will succeed.  My understanding of insert_resource
indicates that both will succeed, and you'll end up with one below
the other.

That's not too much of a problem as long as the drivers also request
the resources before using them.

But that's theory.  I don't know of any situation today where this
is presently true, or would be.

In the end, we can't have your behaviour without also having the
_possibility_ of this problem.  So let's have your behaviour as
it fixes a real problem you're seeing.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/