Re: [git pull 09/14] Uinput: add UI_SET_SWBIT ioctl

[Dmitry Torokhov]

On 11/23/05, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 2005-11-24 at 09:54 +1100, Benjamin Herrenschmidt wrote:
> > On Sun, 2005-11-20 at 01:36 -0500, Dmitry Torokhov wrote:
> > > plain text document attachment (uinput-add-sw-ioctl.patch)
> > > Input: uinput - add UI_SET_SWBIT ioctl
> > >
> > > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
> >
> > All these new ioctl's and no compat layer for 32 bits apps on 64 bits
> > kernels ...
> >
> > I'll send a patch later today for the current ones, but please, do it
> > from day #1 next time :)
>
> Ok, forget my promise, I won't do a compat layer for it today. Way too
> much crap in there, read's of structs made of other structs & unions
> etc... all of this would need compat versions etc... no time for that.
>
> Couldn't you have designed that properly in the first place ?
>

I couldn't event design it improperly ;)

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/