Re: [Linux-fbdev-devel] Re: Console rotation problems

[Geert Uytterhoeven]

On Thu, 24 Nov 2005, Antonino A. Daplas wrote:
> Benjamin Herrenschmidt wrote:
> > Remove bogus usage of test/set_bit() from fbcon rotation code and just
> > manipulate the bits directly. This fixes an oops on powerpc among others
> > and should be faster. Seems to work fine on the G5 here.
> 
> Thanks, I reached a point when my head became muddled with bit 
> manipulations, so I used arch-specific bitops but complete forgot
> that they were atomic :-)

I haven't really looked at the rotation code, but I guess it can be optimized a
lot by using similar techniques like c2p (chunky-to-planar) conversions.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/