Re: [OOPS] sysfs_hash_and_remove (was Re: What protection ....)

[Ingo Molnar]

* Maneesh Soni <maneesh@xxxxxxxxxx> wrote:

> So, IMO, it is necessary to explicitly remove links before 
> unregistering the kobject in case of bidirectional cross symlinks.
> 
> The patch from James, is working, because it is not creating the cross 
> symlink itself.

so, what is your suggestion, what should be done to fix the problem? The 
patch below:

> > +		/*
> >  		sysfs_create_link(&class_dev->dev->kobj, &class_dev->kobj,
> >  				  class_name);
> > +		*/

> > +		/*
> >  		sysfs_remove_link(&class_dev->dev->kobj, class_name);
> > +		*/

isnt fit for upstream inclusion :-)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/