Re: [PATCH] fix to clock running too fast

From: Akira Tsukamoto
Date: Thu Nov 24 2005 - 12:48:03 EST



Ingo Molnar <mingo@xxxxxxx> mentioned:
>
> * Akira Tsukamoto <akira-t@xxxxxxxxxxxxx> wrote:
>
> > This one line patch adds upper bound testing inside timer_irq_works()
> > when evaluating whether irq timer works or not on boot up.
> >
> > It fix the machines having problem with clock running too fast.
> >
> > What this patch do is, if timer interrupts running too fast through
> > IO-APIC IRQ then false back to i8259A IRQ.
>
> thanks - looks good to me.
>
> Acked-by: Ingo Molnar <mingo@xxxxxxx>
>
> Ingo

Thanks,
I regenerated my patch to the latest kernel.

Signed-off-by: Akira Tsukamoto <akira-t@xxxxxxxxxxxxx>

--- linux-2.6.15-rc2-atiix/arch/i386/kernel/io_apic.c.orig 2005-11-20 12:25:03.000000000 +0900
+++ linux-2.6.15-rc2-atiix/arch/i386/kernel/io_apic.c 2005-11-25 02:43:40.000000000 +0900
@@ -1877,7 +1877,7 @@ static int __init timer_irq_works(void)
* might have cached one ExtINT interrupt. Finally, at
* least one tick may be lost due to delays.
*/
- if (jiffies - t1 > 4)
+ if (jiffies - t1 > 4 && jiffies - t1 < 16)
return 1;

return 0;




--
Akira Tsukamoto <akira-t@xxxxxxxxxxxxx> <>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/