Re: [-mm patch] dummy mark_rodata_ro() should be static

[Adrian Bunk]

On Thu, Nov 24, 2005 at 08:56:59AM +0100, Arjan van de Ven wrote:
> On Thu, 2005-11-24 at 06:14 +0100, Adrian Bunk wrote:
> > On Wed, Nov 23, 2005 at 11:35:05PM +0100, Adrian Bunk wrote:
> > 
> > > Every inline dummy function should be static.
> > >...
> > 
> > Sorry, the patch was incomplete.
> 
> ok I was trying to avoid the ifdefs... if you add the ifdefs you might
> as well put the dummy in the header too in a #else clause.

Since it's not architecture specific, it should also move to a header 
under include/linux/.

Any suggestions which one to use?
My first thought was init.h, but this breaks compilation since this 
header is #include'd by assembler code.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/