Re: mousedev parametes not visible in /sys

[Dmitry Torokhov]

On Saturday 26 November 2005 15:08, Jan Engelhardt wrote:
> Hello,
> 
> 
> linux-2.6.13/drivers/input/mousedev.c has some module_params, but they do 
> not show up in /sys, i.e. there is no /sys/modules/mousedev directory at 
> all. Even though it is a compiled-in 'module', I do know that even 
> compiled-ins can get a directory under /sys/modules/, as is the case with 
> a module_param in e.g. drivers/char/vt.c which shows as /sys/modules/vt.
> 
> Can anybody confirm this or know what's wrong?
>

Hi Jan,

They have 0 permission so corresponding attributes are not created.
Something like the patch below shoudl fix that. 

-- 
Dmitry

Input: mousedev - make module parameters visible in sysfs

Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
---

 drivers/input/mousedev.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Index: work/drivers/input/mousedev.c
===================================================================
--- work.orig/drivers/input/mousedev.c
+++ work/drivers/input/mousedev.c
@@ -40,15 +40,15 @@ MODULE_LICENSE("GPL");
 #endif
 
 static int xres = CONFIG_INPUT_MOUSEDEV_SCREEN_X;
-module_param(xres, uint, 0);
+module_param(xres, uint, 0644);
 MODULE_PARM_DESC(xres, "Horizontal screen resolution");
 
 static int yres = CONFIG_INPUT_MOUSEDEV_SCREEN_Y;
-module_param(yres, uint, 0);
+module_param(yres, uint, 0644);
 MODULE_PARM_DESC(yres, "Vertical screen resolution");
 
 static unsigned tap_time = 200;
-module_param(tap_time, uint, 0);
+module_param(tap_time, uint, 0644);
 MODULE_PARM_DESC(tap_time, "Tap time for touchpads in absolute mode (msecs)");
 
 struct mousedev_hw_data {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/