Re: [PATCH 2/2] shared mounts: save mount flag space

[Al Viro]

On Sat, Nov 26, 2005 at 09:55:09PM -0800, Andrew Morton wrote:
> > -	else if (flags & (MS_SHARED | MS_PRIVATE | MS_SLAVE | MS_UNBINDABLE))
> > -		retval = do_change_type(&nd, flags);
> > +	else if (flags & MS_PROPAGATION)
> > +		retval = do_change_type(&nd, flags & MS_REC, data_page);
> >  	else if (flags & MS_MOVE)
> >  		retval = do_move_mount(&nd, dev_name);
> >  	else
> 
> But I don't know how much trauma this would cause.  Hasn't util-linux
> already been patched with the new mount flags?
> 
> If it has, and if it uses the same names for these options, the patched
> mount(8) just won't work.
> 
> The proposed new mount options should be documented somewhere.
> 
> Anyway, I'll let Ram&Al decide on this proposal.

It's
	a) palliative
	b) ugly

Let's face it, mount(2) ABI is getting past its shelf life already.
We'll need saner replacement (not mixing action with the flags and
being really typed) anyway, so let's not introduce more kludges into
mount(2) already messy situation - it's not worth the effort.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/