Re: [Lse-tech] Re: [PATCH 0/7]: Fix for unsafe notifier chain

[Keith Owens]

On Sun, 27 Nov 2005 18:27:25 +0100, 
Andi Kleen <ak@xxxxxxx> wrote:
>On Mon, Nov 28, 2005 at 02:59:05AM +1100, Keith Owens wrote:
>> On Sun, 27 Nov 2005 14:47:36 +0100, 
>> Andi Kleen <ak@xxxxxxx> wrote:
>> >akpm wrote
>> >>   - Introduce a new notifier API which is wholly unlocked
>> >
>> >The old notifiers were already wholly unlocked. So it wouldn't 
>> >even need any changes. Just additional locks everywhere.
>> 
>> Wrong.  
>
>Did you actually read what I wrote? 

Of course I did.  The whole point is that _ALL_ of the existing
notifier chain callback code is racy[*].  Saying that the code can be
left without any changes is simply ignoring the existing races.  They
_ALL_ need to be fixed.

[*] Except for one bit of hand crafted locking in USB.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/