Re: [Fastboot] Re: [PATCH & RFC] kdump and stack overflows

[Vivek Goyal]

On Mon, Nov 28, 2005 at 11:29:29AM -0700, Eric W. Biederman wrote:
> Fernando Luis Vazquez Cao <fernando@xxxxxxxxxxxxxxxxx> writes:
> 
> > On Mon, 2005-11-28 at 06:39 -0700, Eric W. Biederman wrote: 
> >> Fernando Luis Vazquez Cao <fernando@xxxxxxxxxxxxxxxxx> writes:
> 
> > Regarding the stack overflow audit of the nmi path, we have the problem
> > that both nmi_enter and nmi_exit in do_nmi (see code below) make heavy
> > use of "current" indirectly (specially through the kernel preemption
> > code).
> 
> Ok.  I wonder if it would be saner to simply replace the nmi trap
> handler on the crash dump path?
> 
> >> I believe we have a separate interrupt stack that
> >> should help but..
> > Yes, when using 4K stacks we have a separate interrupt stack that should
> > help, but I am afraid that crash dumping is about being paranoid.
> 
> Oh I agree.  If we had a private 4K stack for the nmi handler we
> would not need to worry about overflow in that case.  (baring
> nmi happening during nmis)  Hmm.  Is there anything to keep
> us doing something bad in that case?
> 

Can a NMI happen inside a NMI? As per Intel software developer manual vol3
(section 5.7.1 Handling multiple NMIs), after occurrence of an NMI, CPU
will not accept next NMI till iret is executed. Then it should not be a
problem. I hope, I understood the problem right.

Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/