RE: [BUG] Variable stopmachine_state should be volatile

[Zhang, Yanmin]

>>-----Original Message-----
>>From: Pavel Machek [mailto:pavel@xxxxxx]
>>Sent: 2005年12月1日 18:26
>>To: Zhang, Yanmin
>>Cc: linux-kernel@xxxxxxxxxxxxxxx; Pallipadi, Venkatesh; Shah, Rajesh
>>Subject: Re: [BUG] Variable stopmachine_state should be volatile
>>
>>Hi!
>>
>>> >>Those barriers should already prevent compiler optimalization, no? If
>>> >>they do not, just use some barriers that do.
>>>
>>>
>>> I hit the problem when compiling 2.6 kernel by intel compiler.
>>> How about to change the type of stopmachine_state to atomic_t?
>>
>>That is certainly safest / very conservative solution.
>>								Pavel
Thanks. The functions are not performance sensitive, so atomic_t is ok. Here is the new patch.

Attachment: stopmachine_state_volatile_2.6.15_rc3_v2.patch
Description: stopmachine_state_volatile_2.6.15_rc3_v2.patch