Sorry (was: Re: [2.6.15-rc1+ regression] do_file_page bug introduced in recent rework)

[Blaisorblade]

On Saturday 03 December 2005 11:03, Hugh Dickins wrote:
> On Fri, 2 Dec 2005, Blaisorblade wrote:

> > Indeed, the condition to test (and to possibly BUG_ON/pte_ERROR) is that
> > ->populate must exist for the sys_remap_file_pages call to work.
>
> I'm puzzled.

Don't worry, you're right.

> Both filemap_populate and shmem_populate 
> now test VM_NONLINEAR before calling install_file_pte.

Uff, sorry, you're right - I hadn't seen this change (not mentioned in the 
Changelog, and I'm in shortness of time currently).

I haven't had the time to look even at the whole commit I referred to... (this 
summer I had studied the code for a whole month!).
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/