Re: [PATCH] CPU frequency display in /proc/cpuinfo

[Andi Kleen]

On Sun, Dec 04, 2005 at 02:49:26PM -0500, Lee Revell wrote:
> On Sun, 2005-12-04 at 19:32 +0100, Andi Kleen wrote:
> > On Sun, Dec 04, 2005 at 05:43:35PM +0100, Dominik Brodowski wrote:
> > > On Fri, Dec 02, 2005 at 10:43:20AM -0800, Venkatesh Pallipadi wrote:
> > > > The patch below changes this to:
> > > > Show the last known frequency of the particular CPU, when cpufreq is present. If
> > > > cpu doesnot support changing of frequency through cpufreq, then boot frequency 
> > > > will be shown. The patch affects i386, x86_64 and ia64 architectures.
> > > 
> > > Looks good to me -- however, might this affect userspace cpufreq tools? I'd
> > 
> > They normally use /sys anyways.
> 
> Wrong, lots of userspace programs that need to know the CPU speed get it
> from /proc/cpuinfo.  It would be nice if there were a better API.

Talking about user space governours - I presume that is what 
Dominik ment with "userspace cpufreq tools"

> As long as you don't change the file format it should be OK.

Great that we have your approval.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/