RE: [git pull 02/14] Add Wistron driver

[Yu, Luming]

>On 12/2/05, Yu, Luming <luming.yu@xxxxxxxxx> wrote:
>> I just tested module wistron_btn on  one Acer Aspire laptop after
>> adding one dmi entry.  The wistron_btn found BIOS interfaces.
>> One visible error is the bluetooth light won't turn on upon
>> stroking bluetooth button.
>> Without wistron_btn module, the bluetooth light works.
>>  with acpi enabled, I didn't try acpi disabled)
>>
>
>Did you add the new keymap table with KE_BLUETOOTH to go with 
>that DMI entry?

Yes,  I added.
>
>> wistron_btn polls a cmos address to detect hotkey event.  It
>> is not necessary, because there do have ACPI interrupt triggered upon
>> hotkeys.
>>
>
>Unfortunately ACPI does not route these events through the input layer
>so aside from special buttons (like sleep) it is not very useful.

There are acpi daemon for any evetnts that needs user space attention.
I'm not sure if these events should be routed to input layer.
But, we can do that.

>
>> So, my suggestion is to disable this module when ACPI enabled.
>> We need to implement hotkey support from ACPI subsystem for my
>> Acer aspire laptop.
>
>I do not agree.

For my acer aspire laptop.
I added dmi entry, and keymap.

With acpi disabled, bluetooth light doesn't work
With acpi disabled + wistron module,  bluetooth light doesn't work.

With acpi enabled +  wistron module,  bluetooth light doesn't work

With acpi enabled - wistron module, bluetooth works.
>From these test cases, do you still think wistron driver can help my
laptop?

Thanks,
Luming
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/