Re: [PATCH 01/16] mm: delayed page activation
From: Andrew Morton
Date: Wed Dec 07 2005 - 04:47:39 EST
Wu Fengguang <wfg@xxxxxxxxxxxxxxxx> wrote:
>
> Andrew, and anyone in the lkml, do you feel ok to test it in -mm tree?
Nope, sorry. I am wildly uninterested in large changes to page reclaim.
Or to readahead, come to that.
That code has had years of testing, tweaking, tuning and poking. Large
changes such as these will take as long as a year to get settled into the
same degree of maturity. Both of these parts of the kernel are similar in
that they are hit with an extraordinarly broad range of usage patterns and
they both implement various predict-the-future heuristics. They are subtle
and there is a lot of historical knowledge embedded in there.
What I would encourage you to do is to stop developing and testing new
code. Instead, devote more time to testing, understanding and debugging
the current code. If you find and fix a problem and can help us gain a
really really really good understanding of the problem and the fix then
great, we can run with that minimal-sized, minimal-impact, well-understood,
well-tested fix.
See where I'm coming from? Experience teaches us to be super-cautious
here. In these code areas especially we cannot afford to go making
larger-than-needed changes because those changes will probably break things
in ways which will take a long time to discover, and longer to re-fix.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/