Re: 2.6.13.2 crash on shutdown on SMP machine

[Jeff Collins]

With this patch, my PII Xeon 4 cpu system reaches the 
state of "Powered Down" and stops. (Running Slackware Linux 10.2
with 2.6.14.3 from kernel.org)

At this point, I can power off or hit the reset button
to restart.


Thank you for the patch.


Jeff

On Tue, 6 Dec 2005, Zwane Mwaikambo wrote:

> On Tue, 6 Dec 2005, Clemens Koller wrote:
>
> > Hello, Zwane!
> >
> > > > From what i hear it's this issue;
> > >
> > > http://bugzilla.kernel.org/show_bug.cgi?id=5203
> >
> > Yes it seems to be the same issue.
> > But who is Eric, mentioned in bugzilla? :-]
> > If it makes sense I can test his patch while/before he is pushing
> > it upstream.
>
> Eric is 'Eric Biederman', Jeff tested his patch but there appears to be a
> failure case when there is no power management callback installed. Could
> you please test the following patch?
>
> diff -r 3815424104b0 arch/i386/kernel/reboot.c
> --- a/arch/i386/kernel/reboot.c	Sat Dec  3 07:09:38 2005
> +++ b/arch/i386/kernel/reboot.c	Mon Dec  5 00:44:37 2005
> @@ -359,6 +359,10 @@
>
> 	if (pm_power_off)
> 		pm_power_off();
> -}
> -
> -
> +
> +	local_irq_disable();
> +	if (cpu_data[0].hlt_works_ok)
> +		while (1) halt();
> +	while (1);
> +}
> +
> diff -r 3815424104b0 arch/x86_64/kernel/reboot.c
> --- a/arch/x86_64/kernel/reboot.c	Sat Dec  3 07:09:38 2005
> +++ b/arch/x86_64/kernel/reboot.c	Mon Dec  5 00:44:37 2005
> @@ -159,5 +159,9 @@
> 	}
> 	if (pm_power_off)
> 		pm_power_off();
> +
> +	local_irq_disable();
> +	while (1)
> +		halt();
> }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/