Re: 2.6.15-rc5-mm1 (x86_64-hpet-overflow.patch breaks resumefrom disk)

From: Jan Beulich
Date: Fri Dec 09 2005 - 07:46:11 EST


>>> "Rafael J. Wysocki" <rjw@xxxxxxx> 09.12.05 12:20:05 >>>
>On Friday, 9 December 2005 10:15, Jan Beulich wrote:
>> It's a possible way to address this, but I'd rather just set a flag
>> indicating that the last-whatever values should not be considered
(to
>> get into a state just like after initial boot). Jan
>
>OK, but what is the interrupt handler supposed to do if the
>vxtime.last* values are invalid? I guess assume delta = 0?

As I said, the state should be (re)set to whatever is in effect at
boot.

>BTW, in the interrupt handler there is:
>
> __asm__("mulq %1\n\t"
> "shrdq $32, %%rdx, %0"
> : "+a" (delta)
> : "rm" (vxtime.tsc_quot)
> : "rdx");
>
>Is the "+a" a typo?

Why would you think so?

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/