Re: [PATCH 29/56] DVB (2390) Adds a time-delay to IR remote button presses for av7110 ir input,

[Johannes Stezenbach]

On Fri, Dec 09, 2005, Dmitry Torokhov wrote:
> On 12/9/05, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxx> wrote:
> >  static void input_repeat_key(unsigned long data)
> >  {
> > -       /* dummy routine to disable autorepeat in the input driver */
> > +       /* called by the input driver after rep[REP_DELAY] ms */
> > +       delay_timer_finished = 1;
> >  }
> 
> I always wondered why many IR drivers re-implement autorepeat code
> instead of using autorepeat in the inptu core. Is it because of forced
> (by timer) keyup events?

Remote controls don't generate key-up events (think what would
happen if you press a button and then someone walks in between
while you release the key). Instead they generate key-down
and repeated key-still-down events. The repeat rate generated
by remote controls varies roughly between 100...300 msecs and
even depends on battery level for many remotes.

If you use a timer to simulate key-up after you received no
key-still-down for some time, and use input core autorepeat,
then you get this annoying effect that input core generates
key repeats after you released the key on the remote control.


Johannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/