Re: [PATCH 2/3] i386: CS5535 chip support - GPIO

[Andrew Morton]

Ben Gardner <gardner.ben@xxxxxxxxx> wrote:
>
> +/* These are defined in cs5535.c */
> +extern u32 cs5535_gpio_base;
> +extern u32 cs5535_gpio_mask;

And they should be declared in a header file, please.

Is there a reason for these being exported to non-GPL modules, or can they
be EXPORT_SYMBOL_GPL()?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/