Re: Linux 2.6.15-rc5 bad page with fglrx on Radeon X300

[Hugh Dickins]

On Sat, 10 Dec 2005, Brice Goglin wrote:
> Does anybody out there have ATI drivers working on Radeon X300
> on 2.6.15-rc5 (or -rc[234]) ? They released fglrx 8.20.8 on december 8th.
> I thought they would have fixed the driver for 2.6.15.
> But, I still get bad page and X programs freezing.

The ATI wrapper source is carefully "#if 0"ing a get_page because of the
traditional anomalous behaviour of PageReserved.  2.6.15-rc killed that
anomalous behaviour, so their "#if 0" needs to become a version test.

Big thanks to Martin Drab for testing this (and correcting the stupidity
of my original inverted patch) - tell us if it does not work for you too.

Hugh

--- fglrx.orig/build_mod/firegl_public.c	2005-12-05 15:47:41.000000000 +0000
+++ fglrx/build_mod/firegl_public.c	2005-12-05 17:18:12.000000000 +0000
@@ -2586,7 +2586,7 @@ static __inline__ vm_nopage_ret_t do_vm_
 
     pMmPage = virt_to_page(kaddr);
 
-#if 0
+#if LINUX_VERSION_CODE >= 0x02060f
     // WARNING WARNINIG WARNNING WARNNING WARNNING WARNNING WARNNING WARNNING
     // Don't increment page usage count, cause ctx pages are allocated
     // with drm_alloc_pages, which marks all pages as reserved. Reserved
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/