Re: [PATCH 3/3] [kconfig] Direct use of lxdialog routines by menuconfig

[Kurt Wall]

On Sunday 11 December 2005 07:46 pm, Petr Baudis wrote:
> After three years, the zombie walks again!  This patch (against the latest
> git tree) cleans up interaction between kconfig's mconf (menuconfig
> frontend) and lxdialog. Its commandline interface disappears in this patch,
> instead a .so is packed from the lxdialog objects and the relevant
> functions are called directly from mconf.

> @@ -808,18 +684,22 @@ static void conf(struct menu *menu)
>     }
>     break;
>    case 4:
> -   if (type == 't')
> +   if (active_type == 't')
>      sym_set_tristate_value(sym, no);
>     break;
>    case 5:
> -   if (type == 't')
> +   if (active_type == 't')
>      sym_set_tristate_value(sym, mod);
>     break;
>    case 6:
> -   if (type == 't')
> +   if (active_type == 't') {
>      sym_toggle_tristate_value(sym);
> -   else if (type == 'm')
> -    conf(submenu);
> +   } else if (active_type == 'm') {
> +    if (single_menu_mode)
> +     submenu->data = (void *) !submenu->data;

Shouldn't this be:
     submenu->data = (void *) (long) !submenu->data;

> +    else
> +     conf(submenu);
> +   }
>     break;
>    case 7:
>     search_conf();

Kurt
-- 
The light at the end of the tunnel is the headlight of an approaching
train.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/