Re: [PATCH] PageCompound avoid page[1].mapping

[Nick Piggin]

William Lee Irwin III wrote:
> On Fri, Dec 09, 2005 at 09:56:42PM +0000, Hugh Dickins wrote:
>
> > -	page[1].mapping = (void *)free_huge_page;
> > +	page[1].index = (unsigned long)free_huge_page;	/* set dtor */
> > 	for (i = 0; i < (HPAGE_SIZE/PAGE_SIZE); ++i)
> > 		clear_highpage(&page[i]);
> > 	return page;
>
>
> Hmm, ->lru would be nicer. What prompted the use of ->index?

Yes, agreed. That would rid you of __page_count() too.

Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/