Re: [PATCH] move pm_power_off and pm_idle declaration to common code

[Miklos Szeredi]

> >> Does powerpc still build?  A key question is how do we handle architectures
> >> that always want to want to call machine_power_off.
> >
> > I didn't (and can't) check, but it should.  IIRC multiple declaration
> > of a variable is OK, as long as at most one has an initializer.
> 
> And as long as you don't build with -fno-common.

That seals the argument, since -fno-common is in linux/Makefile.

So the patch wants fixing on powerpc, but I don't feel up to the task.

Somebody with better knowledge of that arch?

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/