Re: [Xen-merge] [patch] SMP alternatives for i386

[Gerd Knorr]

> Overall technically, I like this patch.  Philosophically, I agree with 
> it as well - but might I strongly suggest that you avoid the .section 
> .previous directives and use the nestable .pushsection, .popsection 
> instead?  We are almost to the complexity point with fault handling and 
> alternatives that we will need nested section overrides.

Fortunaly we don't need that at the moment.  And in case we'll really 
need it some day it will not be *that* easy.  The pointers in the fixup 
section will point to the wrong location because we run the UP code not 
in-place but copy it to another address ...

cheers,

  Gerd

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/