Re: [patch 2/5] [RFC] Add MMC password protection (lock/unlock) support

[Russell King]

On Wed, Dec 14, 2005 at 09:31:33AM -0400, Anderson Briglia wrote:
> +	data.blksz_bits = blksz_bits(data_size);
> +	data.blocks = 1;

See my comments in your first mail about this.

> --- linux-2.6.14-omap2.orig/include/linux/mmc/card.h	2005-12-13 11:41:08.000000000 -0400
> +++ linux-2.6.14-omap2/include/linux/mmc/card.h	2005-12-13 11:42:06.000000000 -0400
> @@ -10,6 +10,7 @@
>  #ifndef LINUX_MMC_CARD_H
>  #define LINUX_MMC_CARD_H
>  
> +#include <linux/key.h>
>  #include <linux/mmc/mmc.h>
>  
>  struct mmc_cid {
> @@ -109,4 +110,6 @@ static inline int mmc_card_claim_host(st
>  
>  #define mmc_card_release_host(c)	mmc_release_host((c)->host)
>  
> +extern int mmc_lock_unlock(struct mmc_card *card, struct key *key, int mode);
> +
>  #endif

Given that you're not using the contents of struct key, please don't
include <linux/key.h> here - it adds unnecessary include dependencies.

Instead, use a forward declaration:

struct key;

extern int mmc_lock_unlock(struct mmc_card *card, struct key *key, int mode);

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/