Re: MSI and driver APIs

[Benjamin Herrenschmidt]

> It seems OK to me to say that a driver's probe routine could be called
> with MSI enabled.  A naive driver would just use the irq number from
> the PCI device struct and never care whether interrupts were INTx or
> MSI.  This does fall down for hardware like tg3, where something
> beyond the simple PCI header manipulation is required to turn on MSI use.
> 
> Full MSI-X would be much harder to handle transparently, since
> handling multiple different interrupts typically requires a lot more
> logic in the driver.

You can have multiple MSIs too (they just have to be contiguous in
numbers and aligned on the nearest power of 2).

I'm tempted to leave them enabled and only disable them when
request_irq() is done on the legacy INTx... Does anybody see a problem
with this approach ?

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/