Re: [PATCH] pci device ensure sysdata initialised

From: Greg KH
Date: Thu Dec 22 2005 - 18:50:20 EST


On Thu, Dec 22, 2005 at 11:43:24PM +0000, Andy Whitcroft wrote:
> Greg KH wrote:
>
> > Yeah, but this patch is just papering over that fact :(
> >
> > In fact, you will not put these devices on the proper node with this
> > patch, right? So I don't think it is what you want.
>
> If there is ACPI information for the machine I believe it will put them
> in the correct nodes; otherwise it behaves as we did in -mm1, in that
> they are not correctly located.

Well, why not properly locate them? That's my point :)

It seems you just put a default sysdata on a few places in the tree,
which fixed your boot problems. I'm thinking that isn't fixing the root
issue here of not probing the pci devices properly on these boxes. Does
that make more sense?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/