Re: More info for DSM w/r/t sunffb on 2.6.15-rc6

[David S. Miller]

From: Hugh Dickins <hugh@xxxxxxxxxxx>
Date: Sat, 24 Dec 2005 01:21:07 +0000 (GMT)

> That certainly gets my vote: it should work around the bug correctly
> and effectively without adding any complexity.

And it's even tested successfully :-)

There is an obscure program I wrote a long time ago, which
Michael Bishop spotted, which is in very limited use and doesn't
fall back to MAP_SHARED properly.  But that obscure tool can
be fixed.

> Though really the check ought to be in the sparc and sparc64
> io_remap_pfn_range, which are the guilty parties giving shared write
> access even when none has been asked for.  But I guess it's too risky
> to add failures or change behaviour down there at this stage.

That's a bit too far reaching right now.

> Those "prot = __pgprot(pg_iobits);" lines - any idea why they ever
> got inserted?  I guess to add _PAGE_E in the sparc64 case, and
> whatever the equivalent was in the earlier sparc cases?
> Can they safely be corrected early in 2.6.16?

Corrected?  By that you mean removed?  We have so many hacks
in the tree dealing with this kind of stuff.  For example,
pgprot_noncached() as used by things like snd_pccm_lib_mmap_iomem().
And the uses of that conditionalize with an ifdef, which is how
we get half-implemented interfaces like this which you can't
use consistently, oh and wo' be to the person who defines that
using an inline function and wonders why it never gets ued :-/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/